auto-task(EffectivePotential): TODO to make Higgs potential polynomial basis-independent#1321
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
…l basis-independent Co-authored-by: Claude <noreply@anthropic.com>
|
Thank you for this PR, which will now be reviewed. If submitting to ./Physlib or ./QuantumInfo, please see our review guidelines if you are not familiar with the process. You should expect a back and forth with a reviewer before your PR is merged. See also that link for how to add appropriate labels to your PR. The PR will also go through a number of automated checks. You can learn more about these here, including how to run them locally. If you are submitting to ./PhyslibAlpha there will be a lighter review process, though your PR must still pass the automated checks. If you want to bring attention to this PR, please write a message on this thread of the Lean Zulip. Important: If a reviewer adds an |
morrison-daniel
left a comment
There was a problem hiding this comment.
Actual TODO in the PR description looks good, but another case of a second TODO being added at the same time
Summary
This PR records a single
TODOitem inPhyslib/Particles/StandardModel/HiggsBoson/EffectivePotential.lean.The TODO was human-written; Claude placed it in the appropriate file and
section of the library and verified that the build and linters remain green.
Original user input
What was added
A
TODOcommand just afterapply_eq_polynomial, inside section B. Maximummass dimension, next to the declarations it concerns (
HasMaxMassDimLEandpolynomial):Why this is the right home
HasMaxMassDimLEandpolynomialcurrently express the effective potential asan
MvPolynomial (Fin 4) ℝevaluated onHiggsVec.toRealScalars, i.e. tied toan explicit coordinate choice. The TODO sits directly beside these definitions,
making the intended basis-independent reformulation discoverable to future
contributors. No
TODOfor this already existed.Verification
lake buildsucceeds with the TODO elaborating cleanly (nosorry, no newaxioms, no new warnings).
lake exe runPhyslibLinterspasses../scripts/lint-style.shpasses.Human review